fix: Adding two required arguments on BigQuery hook create_table #55501
Conversation
…od, that were not there before
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@FVidalCarneiro, looks good! Does it make sense to try and add a test? Maybe not, but thought I'd check. |
Hello @jroachgolf84 , I guess we could add one to |
|
Hi, Perhaps @Crowiant who introduced the original breaking change is more familiar with tests to create a new one ? Thank you all :) |
|
Needs tests for this. please look at here -> unit/google/cloud/transfers/test_gcs_to_bigquery.py |
|
hi |
|
There are plenty of tests already available in the test file, I noticed the I also agree that the original contributor that introduced the breaking change is better placed than I to introduce the test :) |
|
@FVidalCarneiro - reach out to me in the Airflow OSS Slack, and we can talk about what writing unit tests would look like for this PR. This is a good opportunity for you! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
Still open issue, who could add expected tests please ? |
Maybe you @kev-datams ? Take over the PR, open yours and add tests. This is how open source works, usually those who need things most are the most likely to contribute them. |
Agree, but no time for it currently unfortunately. |
|
I'll pick this and submit a new PR containing the fix and tests. |
|
New PR with updated tests. |
Adding two required arguments on BigQuery hook create_table method, that were not there before. This is the solution to a bug.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.